Merged
Conversation
there is still a row for the element norms, even if they are not valid. thus the l variable is not necessary, we can use k directly
Member
Author
|
jenkins build this with downstreams please |
kmokstad
approved these changes
Apr 13, 2026
Contributor
kmokstad
left a comment
kmokstad
left a comment
There was a problem hiding this comment.
Assume this is is fine. I've not tested norm output to hdf5 in a long time (if at all).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there is still a row for the element norms, even if they are not valid. thus the l variable is not necessary, we can use k directly